search

hasadna / openmuni-budgets

A web app and web API for storing, accessing, visualizing and comparing budgetary data from Israeli municipalities.
http://openmuni.org.il/
BSD 3-Clause "New" or "Revised" License
15 stars 28 forks source link

Added social auth... #405

Open BeOleg opened 10 years ago

BeOleg commented 10 years ago

2 current issues:

  1. The account_detail view takes another full page refresh to update after adding or removing a social network.
  2. Needs some serious redesigning.
pwalsh commented 10 years ago

Hi @BeOleg there is no need for us to hold on merging this because of the design issues. I'd rather merge it so it is available when we do the next design round.

However, there are some things that need to be done before considering merging it with the codebase:

  1. All of @yprez 's points need to be addressed.
  2. We need basic unit tests that confirm the functionality - we can't merge code related to user registration/login, which is a critical component of the app, without some test coverage, especially around our our case of matching email addresses to "merge" a new social registration/login with existing accounts when there is a match.