search

hasadna / reportit-agent

1 stars 1 forks source link

script (guard): add task to look for the relevant company if it is unkown by the user #41

Closed noamoss closed 5 years ago

noamoss commented 5 years ago

@akariv It is harder now for me to implement this issue, because the local version of report-it agent is connected to the common script, and because I am depending on you to approve my PR before being able to check the result.

Please take over (you can use https://github.com/hasadna/reportit-scripts/commit/73e9c10348c98ea03128dd4667335bcead88e02a, on https://github.com/hasadna/reportit-scripts/pull/2 as a base)

akariv commented 5 years ago

you can change the url in the runner.run() call to point to a local location (e.g. 'assets/script.json')

Then just copy the script.json you're generating to src/assets/ and you can test locally

On Fri, Sep 13, 2019 at 4:25 PM noamoss notifications@github.com wrote:

Assigned #41 https://github.com/hasadna/reportit-agent/issues/41 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/reportit-agent/issues/41?email_source=notifications&email_token=AACAY5PZURL3DFNQWOX5UA3QJOICXA5CNFSM4IFINBP2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTTTCF7Q#event-2632327934, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAY5MIXM43Y6C4EC6ORDLQJOICXANCNFSM4IFINBPQ .

akariv commented 5 years ago

@noamoss

On Fri, Sep 13, 2019 at 7:02 PM Adam Kariv adam.kariv@gmail.com wrote:

you can change the url in the runner.run() call to point to a local location (e.g. 'assets/script.json')

Then just copy the script.json you're generating to src/assets/ and you can test locally

On Fri, Sep 13, 2019 at 4:25 PM noamoss notifications@github.com wrote:

Assigned #41 https://github.com/hasadna/reportit-agent/issues/41 to @akariv https://github.com/akariv.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/hasadna/reportit-agent/issues/41?email_source=notifications&email_token=AACAY5PZURL3DFNQWOX5UA3QJOICXA5CNFSM4IFINBP2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTTTCF7Q#event-2632327934, or mute the thread https://github.com/notifications/unsubscribe-auth/AACAY5MIXM43Y6C4EC6ORDLQJOICXANCNFSM4IFINBPQ .

noamoss commented 5 years ago

thanx. done and deployed.