search

hasadna / reportit-agent

1 stars 1 forks source link

Script uses invalid variable name 'housing_land_type' #50

Closed akariv closed 4 years ago

akariv commented 4 years ago

The script uses this invalid name, which prevents continuing it once it has been set.

noamoss commented 4 years ago

(@akariv please notice to include issues you open on board as well, (I missed this before)

noamoss commented 4 years ago

this was supposed to be a local variable name (_housing_land_type). Fixed via the new script editor.

This issue was fixed but during the check I found #65.

akariv commented 4 years ago

Can't see it - did you deploy the new script?

noamoss commented 4 years ago

@akariv ...probably not - just saved the script though the editor, and rebuilt through travis. what is the missing step (and do I have the permission to perform it?)

akariv commented 4 years ago

I don't see any build in reporit-sctipts - maybe you built a different repo?

On Sat, Dec 14, 2019, 00:14 noamoss notifications@github.com wrote:

@akariv https://github.com/akariv ...probably not - just saved the script though the editor, and rebuilt through travis. what is the missing step (and do I have the permission to perform it?)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/reportit-agent/issues/50?email_source=notifications&email_token=AACAY5KKWFBISC5JRYA2NQLQYQCNFA5CNFSM4I4Y4CS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3M5EI#issuecomment-565628561, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5NYS2FAW2NIZKND663QYQCNFANCNFSM4I4Y4CSQ .

noamoss commented 4 years ago

@akariv you are right, I assumed it should be done through the agent/user build. Just finished the reportit-scripts build, rechecked on live and approved. feel free to verify.