search

hasadna / reportit-agent

1 stars 1 forks source link

typing a task comment/update, enter should rssault a line break, not a submit #56

Closed noamoss closed 4 years ago

noamoss commented 5 years ago

based on Saroj's feedback, when typing a comment/update in a task card, clicking enter is expected to add a line break, currently, it submits the comment.

image

noamoss commented 4 years ago

@akariv checked and approved functionality, but the visual implementation should be repaired, as the submit button is hiding and actually I could not see it. Here is my suggestion:

תמונה

whatismybrowser

akariv commented 4 years ago

Can you please share a full screenshot? Did you by any chance resize the text area?

On Fri, Dec 13, 2019 at 1:22 PM noamoss notifications@github.com wrote:

Reopened #56 https://github.com/hasadna/reportit-agent/issues/56.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hasadna/reportit-agent/issues/56?email_source=notifications&email_token=AACAY5JVWLQK3NNHPJKI7O3QYNWAXA5CNFSM4JKY34PKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVO4UNZQ#event-2881046246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACAY5MZQYQWKV5IIJEKBCLQYNWAXANCNFSM4JKY34PA .

noamoss commented 4 years ago

תמונה

Did you by any chance resize the text area?

That what I thought - it worked/looked fine just when I zoomed out. CTRL+0 brought me back to this problem.

noamoss commented 4 years ago

checked and approved.