hasadna / reportit-agent

1 stars 1 forks source link

don't create a new duplicate task for a report #59

Closed noamoss closed 4 years ago

noamoss commented 4 years ago

piot feedback:

image

We could just prevent adding this task to the specific scenario, but I believe it brings up a more general need - to prevent task duplication per report. The task title is a good validator. I would not change or add any indication to the user (maybe a console log message saying 'tried to open task X but saw there is already an open one, didn't touch'.

noamoss commented 4 years ago

@akariv as a reminder - there were two issues we discussed in the context of this issue:

  1. the replay should run faster.
  2. tasks should not be recreated during the replay.
noamoss commented 4 years ago

checked and approved, Saroj will make another check