Open AzfarInan opened 2 years ago
Bhaia,
Apps targeting Android 12 and higher are required to specify an explicit value for 'android:exported'.
That's why i had to use exported = true.
I tried with exported = false, but that resulted in exception.
I've attached the exception screenshot for exported = false.
On Fri, May 6, 2022, 3:50 PM Hasan Abdullah @.***> wrote:
@.**** commented on this pull request.
In android/app/src/main/AndroidManifest.xml https://github.com/hasancse91/flutter_getx_template/pull/30#discussion_r866666534 :
@@ -8,6 +8,7 @@ @.***/ic_launcher"> <activity android:name=".MainActivity"
- android:exported="true"
Could you please explain the reason of exported=true?
— Reply to this email directly, view it on GitHub https://github.com/hasancse91/flutter_getx_template/pull/30#pullrequestreview-964420277, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMW5L4BTMZZ6QFNRU35ZKZTVITTPVANCNFSM5VFA4M2A . You are receiving this because you authored the thread.Message ID: @.***>
Thanks for the feedback bhaia. I'll implement this and give another pull request
On Thu, May 12, 2022, 6:55 PM Hasan Abdullah @.***> wrote:
@.**** requested changes on this pull request.
Good work. Few things need to be better.
- Radio button icon and Language text both should be clickable. Right now only radio icon (circle) is clickable.
- Cancel button's area is very tiny. Make the clickable area as like as Confirm button. Maybe TextButton widget is more appropriate here.
— Reply to this email directly, view it on GitHub https://github.com/hasancse91/flutter_getx_template/pull/30#pullrequestreview-970798880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMW5L4AEUKXS4CRY643YYW3VJT5S3ANCNFSM5VFA4M2A . You are receiving this because you were mentioned.Message ID: @.***>
Thanks for the feedback bhaia. I'll implement this and give another pull request
Just update the code and push at the same branch. After code pushing, Re-request Review
.
New pull request added: hasancse91:master...AzfarInan:features/multi-language-support
Our repository has been updated. Could you please pull from master and re-request?
Why? (ticket link or issue description)
https://github.com/hasancse91/flutter_getx_template/issues/17
What was done and how?
Integrated multi language support using GetX Updated Settings UI Implemented Alert box for language change Updated localizations
Anything special? (optional)