According to documentation, glimmaXY() receives vectors as x and y axis input, yet it extracts feature names from these vectors using rownames(). This changes the function to extract feature names using names() instead of rownames().
I also add that the example code for the documentation currently works as intended since efit$coefficients is actually a matrix with 1 column, not a vector. It might also be good to check if x and y are vectors and handle incorrect data types as an error or warning.
Thank you authors and maintainers for the great visualisation package, I just wanted to contribute in this small way.
Before fix (feature names are index in dataset):
After fix (feature names are now the supplied feature names (ENTREZ ID)):
Issue first raised here: #88
According to documentation,
glimmaXY()receives vectors as x and y axis input, yet it extracts feature names from these vectors usingrownames(). This changes the function to extract feature names usingnames()instead ofrownames().I also add that the example code for the documentation currently works as intended since
efit$coefficientsis actually a matrix with 1 column, not a vector. It might also be good to check if x and y are vectors and handle incorrect data types as an error or warning.Thank you authors and maintainers for the great visualisation package, I just wanted to contribute in this small way.
Before fix (feature names are index in dataset):
After fix (feature names are now the supplied feature names (ENTREZ ID)):