hascat / HearthRoulette

Hearth using a random Hearthstone toy, item, or spell! Download the latest release from Curseforge, Twitch, WowInterface or right here on GitHub!
MIT License
5 stars 7 forks source link

Covenant Hearthstones are not restricted by current covenant after reaching Renown 80 #14

Closed Bauxite closed 1 month ago

Bauxite commented 2 years ago

Despite the tooltip reading "Can only be used by those pledged to [Covenant]." the covenant-specific hearthstones are usable while pledged to a different covenant. This is unlocked once any character on your account has reached Renown 80 with any covenant.

Is there any way to detect whether the requirements are met and add all the covenant hearthstones to the pool of choices, instead of just the hearthstone from your current covenant? Possibly by checking for achievement ID 15241?

From the 9.1.5 patch notes:

Players who reach 80 Renown with any Covenant will be able to freely switch among any of the four Covenants without cooldown or restriction. In addition, cosmetic rewards that have been earned from a Covenant with which the player has reached 80 Renown may be used even if that character is currently a member of a different one. Both the Covenant switching and the use of cosmetic rewards will also apply to alts once the Renown threshold is reached on any character. Example: A player with a Night Fae Druid at Renown 80 can use appropriate Night Fae cosmetics on their Rogue, even if the Rogue is a member of the Necrolords.

Bauxite commented 2 years ago

Edit: After playing around with this I don't think it's quite as simple as having the renown 80 achievement.

Scenario 1: Player has unlocked all 4 HS toys from the covenants and at least one character on the account has reached renown 80 with each covenant.
Outcome: Any character on the account can use any of the 4 HS toys regardless of current covenant.

Scenario 2: Player has unlocked all 4 HS toys from the covenants. A character on the account has reached renown 80 with Venthyr, Kyrian, and Night Fae, but only renown 60 with Necrolords. Outcome: Characters pledged to Necrolords can use the Necrolord Hearthstone, but any non-Necrolord characters can't use it.

Fortunately there are some hidden achievements that seem to work, will work these into my fork: https://www.wowhead.com/achievement=15242/renowned-kyrian https://www.wowhead.com/achievement=15243/renowned-necrolords https://www.wowhead.com/achievement=15244/renowned-night-fae https://www.wowhead.com/achievement=15245/renowned-venthyr

Bauxite commented 1 year ago

Unfortunately I am no longer able to use this addon, since I switched to MegaMacro and it doesn't play well with this addon's functionality for updating macro contents on the fly. I started to work on some changes for DF, but I can't test it out without re-doing my macros entirely. Removed my PR for now since it's out of date, but the code is still in my fork if you want to take a look.

hascat commented 1 year ago

Taking a look

Bauxite commented 1 year ago

@hascat , here are the changes in my branch: https://github.com/hascat/HearthRoulette/compare/master...Bauxite:HearthRoulette:covenant-toys-update

I'd been using this locally for a while without issue. I've actually switched back to Macro Toolkit from MegaMacro, happy to be using this addon again :)

hascat commented 1 month ago

Sorry for letting this one stagnate! I went with a slightly simpler approach.

hascat commented 1 month ago

included in release v22