hascat / HearthRoulette

Hearth using a random Hearthstone toy, item, or spell! Download the latest release from Curseforge, Twitch, WowInterface or right here on GitHub!
MIT License
4 stars 5 forks source link

Original Hearthstone #26

Open theruan opened 1 month ago

theruan commented 1 month ago

Sometimes the addon attempts to use the original hearthstone item, while some people may keep that in bag, i rarely do, when the addon attempts to use that item, I end up getting stuck, cause it will take sometime(not sure exactly when/how) for it to change the macro. Please either: Remove original hearthstone from rotation OR Give an option to remove the original hearthstone from rotation OR Execute a check looking in the bags for a hearthstone.

hascat commented 1 week ago

The addon should only attempt to use the item if it's in your bags.

Are you seeing this issue when you have the Hearthstone item in your bags, or when you do not have the item in your bags?

What do you mean by "getting stuck"?

theruan commented 1 week ago

Well, it attempts even without the item in bags, i delete the 'basic' hearhstone on every toon, and gives a msg sort of 'you don't have a hearthstone in your bags' or something similar.

If it should do this, then i'm assuming the macro may be recreated on chars in which i didn't delete the hearthstone and/or it was received again on saving a new location and when switching chars it's attempting to use that hearthstone without it being in the bag.

By getting stuck i mean the macro doesn't change to another hearthstone even though the hearthstone attempted isn't in the bags, making the macro unusable.

theruan commented 1 week ago

Oddly i just tried to reproduce the error by editing Data.lua and commenting out the section for toys under addon.HEARTHSTONE_TOY_ID = { } which left me only the "Night Fae Hearthstone" and the hearthstone in the bag as option BUT only the "Night Fae Hearthstone" is being used as option to the macro, not looping to the hearthstone(original item) at all

Also attempted to delete and grab another one in the npc, no change, it stays in the "Night Fae Hearthstone"