form_nonce is ineffective with JavaScript submits, where either the nonce is not regenerated, causing unrelated submits to be registered as dupes, or is regenerated just before submit, thereby causing dupe submits to have unique nonces which they shouldn't.
Funnel has a new mechanism that is entirely server side and depends on request fingerprinting to detect dupes (https://github.com/hasgeek/funnel/pull/2002). However, it will not work while random nonce values are part of the request, so form_nonce has to be removed entirely.
This PR only disables the validator. After downstream references to form_nonce are removed, the field can also be removed.
form_nonceis ineffective with JavaScript submits, where either the nonce is not regenerated, causing unrelated submits to be registered as dupes, or is regenerated just before submit, thereby causing dupe submits to have unique nonces which they shouldn't.Funnel has a new mechanism that is entirely server side and depends on request fingerprinting to detect dupes (https://github.com/hasgeek/funnel/pull/2002). However, it will not work while random nonce values are part of the request, so
form_noncehas to be removed entirely.This PR only disables the validator. After downstream references to
form_nonceare removed, the field can also be removed.