hasgeek / eventframe

Eventframe
16 stars 6 forks source link

Added setup.py #5

Closed anandology closed 12 years ago

anandology commented 12 years ago

Added setup.py, CHANGES.rst and MANIFEST.in

Please merge.

kracekumar commented 12 years ago

requirements.txt contains following.

ordereddict
Flask
https://github.com/hasgeek/coaster/zipball/master
https://github.com/hasgeek/baseframe/zipball/master
Flask-SQLAlchemy
https://github.com/hasgeek/flask-lastuser/zipball/master
https://bitbucket.org/jace/flask-themes/get/tip.zip
requests
simplejson
pytz

whereas setup.py requires contains following

'baseframe',
'coaster',  
'Flask',
'requests'

I created a new virtualenv and downloaded your code. To run the server I made following changes to setup.py,

requires = [
      'baseframe',
      'coaster',
      'Flask',
      'requests',
      'Flask-Themes',
      'Flask-SQLAlchemy',
      'Flask-lastuser',
      'simplejson',
      'pytz',
      'ordereddict'
      ]

mind updating the patch ?

anandology commented 12 years ago

On Wed, Jul 18, 2012 at 12:22 AM, kracekumar reply@reply.github.com wrote:

requirements.txt contains following.

ordereddict
Flask
https://github.com/hasgeek/coaster/zipball/master
https://github.com/hasgeek/baseframe/zipball/master
Flask-SQLAlchemy
https://github.com/hasgeek/flask-lastuser/zipball/master
https://bitbucket.org/jace/flask-themes/get/tip.zip
requests
simplejson
pytz

whereas setup.py requires contains following

'baseframe',
'coaster',
'Flask',
'requests'

I created a new virtualenv and downloaded your code. To run the server I made following changes to setup.py,

requires = [
      'baseframe',
      'coaster',
      'Flask',
      'requests',
      'Flask-Themes',
      'Flask-SQLAlchemy',
      'Flask-lastuser',
      'simplejson',
      'pytz',
      'ordereddict'
      ]

mind updating the patch ?

The remaining ones already come via baseframe. No need to include them as dependencies here.

kracekumar commented 12 years ago

python setup.py install in a new virtualenv didn't succeed.

kracekumar commented 12 years ago

@jace If I am right I need to add

  dependency_links=[
          "https://bitbucket.org/jace/flask-themes/get/tip.zip#egg=flask-themes",
          ]

since pull request isn't merged for flask-themes

kracekumar commented 12 years ago

baseframe setup.py doesn't install Flask-SQLAlchemy, Flask-lastuser, simplejson, pytz, ordereddict.

Here is setup.py for baseframe

import os
from setuptools import setup, find_packages
from setuptools.command.build_py import build_py

here = os.path.abspath(os.path.dirname(__file__))
README = unicode(open(os.path.join(here, 'README.rst')).read(), 'utf-8')
CHANGES = unicode(open(os.path.join(here, 'CHANGES.rst')).read(), 'utf-8')

requires = [
    'Flask',
    'coaster',
    'jsmin',
    'cssmin',
    'Flask-Assets',
    'Flask-WTF',
    'wtforms',
    'bleach',
    ]

class BaseframeBuildPy(build_py):
    def run(self):
        result = build_py.run(self)
        if not self._dry_run:
            curdir = os.getcwd()
            os.chdir(os.path.join(self.build_lib, 'baseframe'))
            os.system("make tinymce")
            os.chdir(curdir)
        return result

setup(name='baseframe',
      version='0.2.6',
      description='Baseframe for HasGeek projects',
      long_description=README + '\n\n' + CHANGES,
      classifiers=[
        "Programming Language :: Python",
        "Programming Language :: Python :: 2.6",
        "Programming Language :: Python :: 2.7",
        "License :: OSI Approved :: BSD License",
        "Operating System :: OS Independent",
        "Intended Audience :: Developers",
        "Development Status :: 3 - Alpha",
        "Topic :: Software Development :: Libraries",
        ],
      author='Kiran Jonnalagadda',
      author_email='kiran@hasgeek.in',
      url='http://github.com/hasgeek/baseframe',
      keywords='baseframe',
      packages=find_packages(),
      include_package_data=True,
      zip_safe=False,
      test_suite='tests',
      install_requires=requires,
      cmdclass={'build_py': BaseframeBuildPy},
      dependency_links=[
          "https://github.com/hasgeek/coaster/tarball/master#egg=coaster",
          ]
      )
jace commented 12 years ago

@kracekumar Baseframe has no dependency on any of these items.

kracekumar commented 12 years ago

@jace yes, that is the reason we need to add those to eventframe setup.py