switched dangerous default arguments to None

hasgeek / hasjob

Hasjob, the Hasgeek job board

https://hasjob.co

GNU Affero General Public License v3.0

235 stars 80 forks source link

switched dangerous default arguments to None #635

Open shayneofficer opened 2 years ago

shayneofficer commented 2 years ago

Per the code sniff here using mutable lists/dictionaries as default arguments is a bug risk.

jace commented 2 years ago

Hi, I was on holiday and missed this. I’m not sure why you’ve closed the PR. In any case, I’ve implemented similar fixes in #637.

shayneofficer commented 2 years ago

Hi @jace ! no worries, thanks for the response 😄 I closed it since one of the build pipeline checks said I introduced a new bug I think - happy to re-open if you think this change is valuable though!

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}