hasgeek / imgee

Image manager
0 stars 1 forks source link

Images should not be cropped when showing thumbnails #13

Open anandology opened 11 years ago

anandology commented 11 years ago

It looks very odd here https://images.hasgeek.com/pyconindia

jace commented 11 years ago

I can't see that page because I'm not an owner of the pyconindia organization. We chose to show square-cropped thumbnails as that gives us more flexibility with the UI layout, allowing us to design something that works on both desktop and mobile.

However, I do agree it looks odd if you aren't expecting it.

anandology commented 11 years ago

This is what I see.

imgee-cropped-images

jace commented 11 years ago

Looks like cropping was a bad idea. It works for photos but not logos.

miteshashar commented 11 years ago

We could fit the image into the square thumbnail. In some (rare)cases that would reduce the visibility of the logo in the thumbnail.

anandology commented 11 years ago

Shouldn't we be doing something like this?

screen shot 2013-07-08 at 5 06 18 pm

jace commented 11 years ago

Google Search, Plus and others have switched to using thumbnails with the original aspect ratio, but with a layout engine that fills them on screen without gaps. This is similar to what can be achieved with Masonry.js, except Masonry uses vertical layout while Google, et al use horizontal layouts.

Given that the UI is unusable with cropped logos, I recommend we switch to uncropped thumbnails or content-aware cropping immediately. (The latter is non-trivial and may be for another time.)