search

hasgeek / internship-test-android

Android test for HasGeek's internship.
6 stars 6 forks source link

Regarding APIService class #11

Open arp95 opened 7 years ago

arp95 commented 7 years ago

Hi karthik, What do you mean by using APIService class ? Are you referring to using retrofit api call?

karthikb351 commented 7 years ago

I'm referring to this class - https://github.com/hasgeek/internship-test-android/blob/master/app/src/main/java/com/karthikb351/mobiledevinternshiptest/network/APIService.java

All it should do is build the GitHubApiInterface (with Retrofit) with GitHub's API's URL.

The Quick start for Retrofit uses almost the same example - https://square.github.io/retrofit/

arp95 commented 7 years ago

Just to clarify the stuff is going on like this, I make a call to APIService class which builds a retrofit object inturn calls the github api , then the githubService interface takes all the json stuff and converts it . Am i going right?

the-dagger commented 7 years ago

@arp95 Yes exactly! That's how it is supposed to be done. :+1:

arp95 commented 7 years ago

Regarding the repos i want to list , will listing the repos of hasGeek will work ? An should i make each item of the recyclerview clickable if details screen is needed?

the-dagger commented 7 years ago

@arp95 The repos of hasgeek will work just fine. :+1: Also, there is nothing mentioned in the prerequisite about adding onClick for the recyclerView items, so I don't think that it is compulsory.

arp95 commented 7 years ago

@karthikb351 have completed the mentioned task. is it fine submitting a pull request right now or do something more to this task?