Tooltip

[Aditya3403]

I have created the tooltip for the icons. Kindly check and pls inform me if any changes are required. Kindly merge my PR if everything are alright. Thank You.

[netlify[bot]]

✔️ Deploy Preview for hashdefine-whiteboard ready!

🔨 Explore the source changes: fa81d9594caea48a811e619e0d81f2572941f60d

🔍 Inspect the deploy log: https://app.netlify.com/sites/hashdefine-whiteboard/deploys/6222488b67a86e0007694b1b

😎 Browse the preview: https://deploy-preview-20--hashdefine-whiteboard.netlify.app/

[vedant-jain03]

@Aditya3403 Add a screenshot or a clip describing the solution.

[Aditya3403]

@vedant-jain03 I have made the necessary changes. Kindly review and inform for further changes if required. Thank You.

[Aditya3403]

@Aditya3403 Add a screenshot or a clip describing the solution.

@vedant-jain03 what kind of solution are you talking about. Pls elaborate on this.

[vedant-jain03]

@Aditya3403 Add a screenshot or a clip describing the solution.

@vedant-jain03 what kind of solution are you talking about. Pls elaborate on this.

I was asking to share a screenshot of output in localhost, what you have made!

[vedant-jain03]

@Aditya3403 Remove package.lock file from commit.

[Aditya3403]

@Aditya3403 Remove package.lock file from commit.

Removing sir

[Aditya3403]

@vedant-jain03 I have removed the package-lock.json. Kindly check now and if everything alright kindly merge it. thank You.

[vedant-jain03]

@vedant-jain03 I have removed the package-lock.json. Kindly check now and if everything alright kindly merge it. thank You.

1. You have removed the file from the codebase, I request changes to remove from your commit.
2. Kindly share screenshot of final output in localhost of tooltip you have implemented

[Aditya3403]

Kindly check.

[Aditya3403]

@vedant-jain03 how can I remove package-lock.json from the commit you are saying. Kindly guide me.

[vedant-jain03]

@vedant-jain03 how can I remove package-lock.json from the commit you are saying. Kindly guide me.

ref: https://stackoverflow.com/questions/18357511/git-remove-committed-file-after-push

[Aditya3403]

@vedant-jain03 how can I remove package-lock.json from the commit you are saying. Kindly guide me.

ref: https://stackoverflow.com/questions/18357511/git-remove-committed-file-after-push

@vedant-jain03 Kindly guide me what command do I need to write as it's not very clear from the reference. Thank You.

[Aditya3403]

Rest all changes I have done. I am struck at this point only.

[vedant-jain03]

Rest all changes I have done. I am struck at this point only.

Try this blog: https://devconnected.com/how-to-remove-files-from-git-commit/

• You need to get back to your last HEAD
• You need to remove the package-lock file from the local commit
• Then push forcefully

[Aditya3403]

Rest all changes I have done. I am struck at this point only.

Try this blog: https://devconnected.com/how-to-remove-files-from-git-commit/

• You need to get back to your last HEAD
• You need to remove the package-lock file from the local commit
• Then push forcefully

When I did git ls-files same as in the reference there is no package-lock file instead there is package file. What should do I do now. Kindly help.

[Aditya3403]

I have made the PR with required changes. Kindly check now.

[vedant-jain03]

@Aditya3403 Could you please open a fresh PR

• With new updates, pull the code first before pushing.
• If you have used a new package so just add that line of code from package-lock.json, not the whole code. Closing this PR, hoping to review your PR soon.

[Aditya3403]

@vedant-jain03 have you reviewed and merged my PR?

[vedant-jain03]

@vedant-jain03 have you reviewed and merged my PR?

Your implementation is good but have some clashes on merging. Actually, I closed it and expect you to create a fresh PR including points listed in my recent thread.

[Aditya3403]

As I have created tooltips for the icons so can I make PR for the same.

On Sat, 5 Mar 2022, 19:02 Vedant Jain, @.***> wrote:

@vedant-jain03 https://github.com/vedant-jain03 have you reviewed and merged my PR?

Actually, I closed it and expect you to create a fresh PR including points listed in my recent thread.

— Reply to this email directly, view it on GitHub https://github.com/hash-define-organization/Hash-Whiteboard/pull/20#issuecomment-1059765638, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVRAKFFJHIGUB6LJXDU2DMLU6NO6VANCNFSM5PXPWPBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[vedant-jain03]

yepp again.

[Aditya3403]

Can pls tell me that the recent PR I have made was it alright or do I need to look at it again?

On Sat, 5 Mar 2022, 19:22 Vedant Jain, @.***> wrote:

yepp again.

— Reply to this email directly, view it on GitHub https://github.com/hash-define-organization/Hash-Whiteboard/pull/20#issuecomment-1059768936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVRAKFHM424BD4LEM2U6QC3U6NRJPANCNFSM5PXPWPBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

[vedant-jain03]

Can pls tell me that the recent PR I have made was it alright or do I need to look at it again? … On Sat, 5 Mar 2022, 19:22 Vedant Jain, @.> wrote: yepp again. — Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVRAKFHM424BD4LEM2U6QC3U6NRJPANCNFSM5PXPWPBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

The implementation for tootip was good and as expected but that package.lock and conflicting files could be problem after merging. So better to make a fresh PR with same implementation of tooltip and only included package.-lock json file with package info not whole new package-lock file.

[Aditya3403]

When you are available? Can we have a meet inorder to discuss the issues with my PR as I want to complete this task by today anyhow.I am available after 4pm.Thank You.

On Sat, 5 Mar 2022, 20:57 Vedant Jain, @.***> wrote:

Can pls tell me that the recent PR I have made was it alright or do I need to look at it again? … <#m1440582333213269674> On Sat, 5 Mar 2022, 19:22 Vedant Jain, @.> wrote: yepp again. — Reply to this email directly, view it on GitHub <#20 (comment) https://github.com/hash-define-organization/Hash-Whiteboard/pull/20#issuecomment-1059768936>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVRAKFHM424BD4LEM2U6QC3U6NRJPANCNFSM5PXPWPBA https://github.com/notifications/unsubscribe-auth/AVRAKFHM424BD4LEM2U6QC3U6NRJPANCNFSM5PXPWPBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.>

The implementation for tootip was good and as expected but that package.lock and conflicting files could be problem after merging. So better to make a fresh PR with same implementation of tooltip and only included package.-lock json file with package info not whole new package-lock file.

— Reply to this email directly, view it on GitHub https://github.com/hash-define-organization/Hash-Whiteboard/pull/20#issuecomment-1059783067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVRAKFGQKIZ2ZPUSGUJ6YWTU6N4NXANCNFSM5PXPWPBA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>