Closed Shubham29012001 closed 2 years ago
Name | Link |
---|---|
Latest commit | 5cf34d256018063133052da48d9096e57055696a |
Latest deploy log | https://app.netlify.com/sites/hashdefine-whiteboard/deploys/62516e4c45fe3c00086c0d52 |
Deploy Preview | https://deploy-preview-49--hashdefine-whiteboard.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hey @vedant-jain03, you can checkout the PR.
@Shubham29012001 good work
But you have rewritten lines of codes in Main.js
and as a result, it is showing unexpected added lines and deleted lines of code, kindly just add the implementation for this function and undo the code which is not being manupulated with this function.
Can you explain the reason why you added some extra node-modules in package-lock.json file?
Hey @vedant-jain03, since I am using the prettier extension. It automatically prettifies the codes we open. I have opened Main.js just to check the code and the prettier had just prettified the code and nothing else. There is no code changes in main.js from my side and the website is working perfectly well. For package-lock.json and package.json, I have used a lightweight package react-component-export-image.
Hey @vedant-jain03, since I am using the prettier extension. It automatically prettifies the codes we open. I have opened Main.js just to check the code and the prettier had just prettified the code and nothing else. There is no code changes in main.js from my side and the website is working perfectly well. For package-lock.json and package.json, I have used a lightweight package react-component-export-image.
Hmm, I see But I suggest you not to use auto file modification extension, not for at least open source as it may lead to unnecessary code line credit. I got the thing about node modules now. Good work 👍🏼
Hey @vedant-jain03, yes I will now make sure that I don't use auto prettify on code. Thanks for your suggestion. Can you please look out at the other issue created by me regarding the tooltip too? I have already implemented it. Just need to create a separate PR for it.
Fix #46, I have developed the export image functionality. Please assign the GSSoC'22 and Level label on the issue so that it would contribute to my efforts.