hash-define-organization / Hash-Whiteboard

Whiteboard Built with ReactJS and Material UI 🚀❤️
https://hashdefine-whiteboard.netlify.app/
MIT License
23 stars 39 forks source link

Pencil Thickness Slider #53

Closed arzitmahajan closed 2 years ago

arzitmahajan commented 2 years ago

Pencil thickness could be changed using the slider

netlify[bot] commented 2 years ago

Deploy Preview for hashdefine-whiteboard ready!

Name Link
Latest commit 48f5761e88e8dd2ee27984aa84df10c9410bd264
Latest deploy log https://app.netlify.com/sites/hashdefine-whiteboard/deploys/626ec47b719a0b00089d73ec
Deploy Preview https://deploy-preview-53--hashdefine-whiteboard.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

arzitmahajan commented 2 years ago

26 Please review the PR and mark appropriate labels

vedant-jain03 commented 2 years ago

Why you delete lock file?

arzitmahajan commented 2 years ago

This error was persisting in previous PR also can you tell me how to recover the lock file I tried npm install also but it didn't worked

vedant-jain03 commented 2 years ago

I guess you are not commiting the files in the correct directory. In most of the cases this is only the problem or say small mistake.

arzitmahajan commented 2 years ago

I created a branch then made changes in code and then pushed it after committing using [ git push -u origin "branch name" ]

arzitmahajan commented 2 years ago

Please check now

arzitmahajan commented 2 years ago

I directly pasted the lock files

vedant-jain03 commented 2 years ago

@arzitmahajan Good work When you format the file it means you have added something(space) and as result it get add in number of lines. Your solution required 50 LOC but it is giving 400+ this is the reason for it. Please be sure from next time, I hope you got something new.

arzitmahajan commented 2 years ago

Yes I noticed I don't why that happened its first time I am facing this kind of issue even there were spaces in lock file it was deleted . I will try my best that this thing don't happen again thanks a lot for approving this PR.