search

hash-define-organization / Hash-Whiteboard

Whiteboard Built with ReactJS and Material UI 🚀❤️
https://hashdefine-whiteboard.netlify.app/
MIT License
23 stars 39 forks source link

Implement Key-Binding on Icons #55

Closed Shubham29012001 closed 2 years ago

Shubham29012001 commented 2 years ago

Fix #50

Added Keybinding on icons. Following are the keys code that corresponds to the certain function:

  1. u - undo
  2. r - redo
  3. s - makelive
  4. o - makeoffline
  5. t - eraser
  6. p - color-picker
  7. c - clear
  8. q - zoomin
  9. w - zoomout

I have used "React-KeyBinding-Component" module packages for implementing the keybinding. Hey @vedant-jain03, do check it out.

netlify[bot] commented 2 years ago

Deploy request for hashdefine-whiteboard pending review.

Visit the deploys page to approve it

Name Link
Latest commit 23bb5c35e3d9beeae294caedc0c8246ace0884f3
vedant-jain03 commented 2 years ago

Hey @Shubham29012001 it seems you have not pulled new changes in Main.js The implementation looks great. Please resolve the conflicts and commit it again.

I guess giving key binding of just letters is not so professional we can have Ctrl for all bindings and for redo, we can have Ctrl + Shift as Ctrl + R means reload, WDYT?