hash-gaming / slackproval

The lightweight slack approved system for managing invites to an open slack community
MIT License
4 stars 0 forks source link

Fix error on nil changed_by #46

Closed michaelstephens closed 4 years ago

michaelstephens commented 4 years ago

Purpose

We do not always have a user associated to a specific change, the prime example is when a user requests access, the Request is created, but no user is associated with that action. When that happens, we break the audit log because we try to do a lookup on a non existent user_id

This change will gracefully fail on a nil user lookup, and display no text for the Changed By column