Closed JamesCullum closed 3 years ago
For the docker image, we could use an existing Docker Hub pipeline. Created PR here: https://github.com/heywoodlh/dockerfiles/pull/1
@JamesCullum Sure, I'd like that too. I am currently working on another project. As soon as I am done with that, I'll set it up as well.
The Dockerfile has been merged and we can refer to that Docker build: https://hub.docker.com/r/heywoodlh/evilginx2
What about a CI/CD pipeline for testing and releases? This would make future maintenance easier and prevents issues like the current one, where the current version doesn't match.
If you can add me as a contributor, I can set up the pipelines on TravisCI similar to what I've done with https://github.com/FIDO-Tools/fido2-library
Can you pull a request if possible or if you can get me on email?
@hash3liZer Sent you another email two days ago - the tests are ready to go and I can set up the pipeline. However I currently do not have permission to install apps or add releases. Could you change my permission, so that I can set up Travis?
Check your email now.
Thanks, received and accepted now. However the permissions are still insufficient to install apps.
EDIT: Looks like this requires admin permission. However if you install it once, it should allow me to configure it.
@hash3liZer Can you install Travis, so that I can configure it?
Due to no feedback, I've decided to use Github Actions, as it requires no app installation. The only thing missing now is adding one secret, that I've sent via email.
@JamesCullum Hi, Sorry to have you waited. I was in hospital for some serious health issues. Can you tell me which Secret?
Hey @hash3liZer - no worries, hope you're feeling better now :) I've sent you an email with a secret called "REDDITPASSWORD" and the password to the test account.
Gotcha.
Great - test pipeline works now and the building one as well 👍
PLEASE READ THE POSTING GUIDELINES AND ANSWER THE QUESTION BEFORE POSTING, OTHERWISE ISSUE WILL BE CLOSED AND MARKED AS INVALID
Please type in "I CONFIRM" below if you confirm the sentences above or otherwise make some funny remark:
I CONFIRM
Thanks!
As the releases of the official one are not updated (and all issues were removed), and this fork appears to be the new maintained version, we should as well create a build pipeline to provide binaries or at least an up-to-date Docker image.
All of this can be set up once and will run automatically and for free, so that people can use it easier.