search

hashbangcode / vlad

Vlad - Vagrant LAMP Ansible Drupal
173 stars 53 forks source link

Dev centos #199

Closed mbarcia closed 9 years ago

mbarcia commented 9 years ago

CentOS was broken (majority of broken components found under Windows), as reported in #195. This PR restores CentOS.

This PR merges PRs #197 and #198.

philipnorton42 commented 9 years ago

Again, this pull request contains changes that shouldn't be in Vlad (the role based settings in the main settings file). As such I'm going to close this. Sorry, I hate putting a downer on people doing work. If we can sort that issue out then I'm happy to merge everything you have done in these issues all together :)

mbarcia commented 9 years ago

Philip, no problemo, I changed my mind after creating #197 when I discovered _includevars, but by then I was already testing the other stuff in here.

I chose to divide features by branch (incrementally) but the actual branch being tested both in Ubuntu and CentOS was this one. And this branch in my local was already including the changes contained in the other two (#198 and #197).

As #197 was then significantly reduced (the mysql stuff was removed), I think #198 and #199 can be re-rolled without #197, they'd just need some testing before creating new requests.

I will get back to these as soon as I can, cheers.