Closed christopher-hopper closed 8 years ago
There's been a test failure but on inspection it seems related to widespread usage of a deprecated ansible feature:
[ANSIBLE0008] deprecated sudo feature
Seems that is something larger than this change. Either fix the usages of sudo
or update the tests to ignore deprecation warnings.
Hi @christopher-hopper, thanks for the PR. Would you mind resubmitting this against Vlad's dev branch as per http://vlad-docs.readthedocs.org/en/latest/contributing/contributing
There's an open issue to update Vlad's use of sudo
to become
so this is on our radar and will be sorted soon. In the meantime I've made some adjustments to the tests run on Travis.
Thanks again!
@danbohea will do.
As a help to contributors like me, could you add a file to the repository with guidelines for contributors. In it you could provide some guidance on which branch is the correct one to use when fixing bugs and pushing pull requests.
Fix for issue #340
The ansible template module expands relative paths for a template
dest
option as relative to the destination, not relative to the playbook. This means relative to theVagrantfile
path for the purposes of this playbook, which is using theansible
provisioner to execute commands on the Vagrant Host machine.See documentation at: