search

hashbangcode / vlad

Vlad - Vagrant LAMP Ansible Drupal
173 stars 53 forks source link

Remove username and password to force machine keys #366

Closed devkinetic closed 7 years ago

devkinetic commented 7 years ago

Now that pantheon can use machine tokens, we should stop using username and password in the vlad_settings file. I created a separate pull request on https://github.com/hashbangcode/ansible-role-pantheon-cli/pull/5 to handle upgrading the CLI version.

Until that is implimented, you can override it in your vlad_settings.yml file with:

pantheon_cli_version: 0.11.4

devkinetic commented 7 years ago

It should also that be noted that in the current implementation, using the old cli and user/pass that terminus will always pull down an empty files zip. Once this is upgraded with cli and tokens, the correct files are pulled.

philipnorton42 commented 7 years ago

I don't use pantheon so I'm probably not in the best position to comment on this. Happy to pull it in if there are no objections :)

dixhuit commented 7 years ago

The default version of Pantheon CLI has now been bumped so no need to override pantheon_cli_version in vlad_settings.yml anymore.