search

hashbangcode / vlad

Vlad - Vagrant LAMP Ansible Drupal
173 stars 53 forks source link

Added a centralised db settings file which can be included if it exists #93

Closed johnennew closed 10 years ago

johnennew commented 10 years ago

Suggestion to add a centralised db settings file. This can then be included in the site's settings.php code like this, so requiring the correct db settings for the environment.

if (file_exists('/var/www/vlad-db-settings.inc')) {
  require '/var/www/vlad-db-settings.inc';
}
dixhuit commented 10 years ago

This would make Vlad too opinionated IMO :) There are many ways to handle local/unique settings in Drupal and no single approach is "correct". I don't think it's Vlad's place to tell you how to do it. This is the kind of thing that the custom role is there for (oddly, it's on my todo list for my own custom role).

Are you at DrupalCon right now? If so, tweet me @dan_bohea if you'd like to ask questions or make suggestions :)

johnennew commented 10 years ago

You are probably right, although I don't think adding this in forces people to use it - just provides it should it be needed - I mostly did this to create a pull request, I've not done it before :)

dixhuit commented 10 years ago

Fair play for trying out pull requests - I certainly don't want to discourage that :)

Respectfully closing as "Won't fix" for reasons already discussed. Keep the PRs coming!