hashberg-io / dag-cbor

Python implementation of the DAG-CBOR codec for IPLD.
https://dag-cbor.readthedocs.io
MIT License
13 stars 6 forks source link

bug: DAG-CBOR Links don't include Multibase prefix (0x00) #1

Closed d70-t closed 2 years ago

d70-t commented 2 years ago

First of all, thank you for providing this library :+1:

When trying to create DAG-CBOR data with this libray, I discovered that go-ipfs is not able to import data created this way. Further investigation showed that the encoder doesn't include the Multibase prefix (0x00) as required by the IPLD spec.

sg495 commented 2 years ago

Thank you for this, good catch 👍