Misc. improvements, including no-op running without assuming a role

hashbrowncipher / aws-roleshell

An aws-cli plugin that loads IAM Role credentials into environment variables

MIT License

15 stars 2 forks source link

Misc. improvements, including no-op running without assuming a role #1

Closed amiryal closed 8 years ago

amiryal commented 8 years ago

Hi,

Congratulations on a simple and elegant great tool! I am creating this PR as a way to let you know that I am working on some patches, to prevent duplicate work. I would have held off submitting the PR until it’s battle tested in a production environment, but since the refactor is quite substantial, I think it’s best to make it known in advance. If you don’t pull the changes by then, I will write here again once ready.

Regards, Amir

hashbrowncipher commented 8 years ago

It looks great so far.

amiryal commented 8 years ago

Ok, patch set ready to pull!

The list of user-visible changes:

Allow no-op running, for exporting environment variables without assuming a role.
Add AWS_DEFAULT_REGION to exported variables.
Unset variables from environment if not explicitly set by roleshell.
Restore support for dropping into a shell using --shell.

Cheers.

hashbrowncipher commented 8 years ago

Awesome! Thanks for contributing.