search

hashcat / princeprocessor

Standalone password candidate generator using the PRINCE algorithm
Other
425 stars 98 forks source link

Add vs set #8

Closed Sc00bz closed 9 years ago

Sc00bz commented 9 years ago

https://github.com/jsteube/princeprocessor/blob/0f8b0ab32fcd98e1ee6ec3f7ead20d73d4c45b32/src/pp.c#L736-L740 Should probably be:

elem_ks (elem_buf, db_entries, elem_buf->ks_cnt); // CHANGED: tmp -> elem_buf->ks_cnt
mpz_add (total_ks_cnt, total_ks_cnt, elem_buf->ks_cnt); // CHANGED: tmp -> elem_buf->ks_cnt

or at least

elem_ks (elem_buf, db_entries, tmp);
mpz_set (elem_buf->ks_cnt, tmp); // CHANGED: mpz_add -> mpz_set
mpz_add (total_ks_cnt, total_ks_cnt, tmp);

This makes it clearer what is going on.

jsteube commented 9 years ago

You're right, using mpz_set() actually was what I wanted to use.