search

hashgraph / MyHbarWallet

🟩 MyHbarWallet is a free, client-side interface helping you interact with Hedera™ Hashgraph.
https://myhbarwallet.com/
Apache License 2.0
71 stars 44 forks source link

Access by Hardware popup displays [object Object] #373

Closed Cooper-Kunz closed 4 years ago

Cooper-Kunz commented 4 years ago

Attempting to use the site & access account via Ledger & I'm getting the following popup.

Not sure what it is intended to display.

Screen Shot 2020-03-02 at 8 14 22 PM

mehcode commented 4 years ago

Can you confirm your version? Check the footer at the bottom. Latest should be: v0.5.0+08cf150.

Cooper-Kunz commented 4 years ago

Yes, it seems to be v0.5.0+08cf150 @mehcode

mehcode commented 4 years ago

Additionally please state your browser, browser version, OS, etc.

mehcode commented 4 years ago

I just tried on macOS Catalina 10.15.3, Chrome 82 and it worked fine. The specific screen you show is a bug we had a few versions ago. I don't think it's possible we use the alert function any more.

Please give it a go on a private browser tab at least to make sure there isn't some cache somewhere.

Cooper-Kunz commented 4 years ago

Thanks for your help @mehcode! Seems to be a much bigger improvement, so i'm sure I had something cached. It's harder to recreate in private, but for instance, if I'm on a different app, e.g. bitcoin, or choose "X" to "exporting public key #0" it still occurs. Far less likely, but be great to get a better error message.

Cooper-Kunz commented 4 years ago

Also for some reason when the app cancels, e.g. I push "X" or whenever there's an error, MyHbarWallet seemingly attempts to open my mailing application. I can send a video over Slack or similar, if needed.

mehcode commented 4 years ago

@Cooper-Kunz I can recreate that alert issue you're getting. I'm honestly quite stumped. It's not supposed to be able to happen as we simply don't call alert anywhere in our code. This means that some library that's in use at that time is calling alert.

Also for some reason when the app cancels, e.g. I push "X" or whenever there's an error, MyHbarWallet seemingly attempts to open my mailing application. I can send a video over Slack or similar, if needed.

I'd appreciate a video if you can. When an error happens an internal error dialog should pop-up and if you click the submit button there it should open up your mail client. I'm curious how it's occurring for you.

mehcode commented 4 years ago

Going to close the issue as the opening issue is not occuring.