search

hashgraph / hedera-block-node

New Block Node services
Apache License 2.0
1 stars 0 forks source link

CI: Add a Workflow on the CI to verify that All PRs have correct labels, milestone and assigned to someone. #28

Open AlfredoG87 opened 2 weeks ago

AlfredoG87 commented 2 weeks ago

Problem

Sometimes PRs get merged that don't have all the necessary Properties like: Assignees, Labels and Milestone set.

This makes it harder to find it afterwards, to generate release notes and to find out historical PRs that were part of a given milestone.

Solution

Create a CI Check to verify those fields are set, and make it rquiered.

There are 2 approaches that can be used to Create such Gate:

  1. https://github.com/hashgraph/hedera-services/blob/develop/.github/workflows/flow-pull-request-formatting.yaml
  2. https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/.github/workflows/pr-label-milestone-check.yml

Option number 2 is more flexible, but is also more complex. I would recommend to implement option number 1 and only if needed on the future to enforce more checks, like making sure that the PR has an associated Issue(s), and that the issue also has labels, assignees and milestone set.

Alternatives

No response