search

hashgraph / hedera-docs

Welcome to the official Hedera documentation repository.
https://docs.hedera.com
59 stars 107 forks source link

fix: clean up of the `.gitbook/assets` directory -- rename with consistency + remove unused #343

Open bguiz opened 1 year ago

bguiz commented 1 year ago

Description

Problem

Solution

Steps to reproduce

(1) On Mac or Linux, clone this repo

git clone git@github.com:hashgraph/hedera-docs.git

(2) Observe the warnings in the output

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  '.gitbook/assets/Network-topology (1).jpg'
  '.gitbook/assets/network-topology (1).jpg'
  '.gitbook/assets/Network-topology.jpg'
  '.gitbook/assets/network-topology.jpg'
  '.gitbook/assets/Smart Contracts.png'
  '.gitbook/assets/smart contracts.png'
  '.gitbook/assets/Token Service.png'
  '.gitbook/assets/token service.png'

(3) List the files within that directory

ls hedera-docs/.gitbook/assets

(4) Observe the list of files output.

0.16.1.png
0.17.png
0.27.4_results copy (1).key
0.27.4_results copy.001.jpeg
0.27.4_results copy.key
0.28.0_results.001.jpeg
0.29.2.png
0.30_results.001.png
0.31_results.001.png
0.34.1.001.png
0.35_results.001.jpeg
1 (1).png
1 (2).png
1.png
11 (1).png
11.png
12.png
1278172.jpg
13.png
14.png
2 (1).png
2 JSON (1).png
2 JSON.png
2.png
22.png
23.png
28_ultraviolet (1) (1) (1) (1).jpg
28_ultraviolet (1) (1) (1) (2).jpg
28_ultraviolet (1) (1) (1).jpg
28_ultraviolet (1) (1) (2).jpg
28_ultraviolet (3).jpg
3 (1).png
3.png
4 (1).png
4.png
5.png
7.png
BLADE.png
Built On Hedera _ BLACK (1).png
Built On Hedera _ BLACK.png
Built On Hedera _ WHITE.png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (2) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1) (1) (3).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (2) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (2) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (2) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (2) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (2) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (2) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3) (3).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1) (3).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (2) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (2) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (2) (3).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1) (1).png
Built On Hedera _ WHITE_Background (1) (1) (2).png
Built On Hedera _ WHITE_Background (1) (1).png
Built On Hedera _ WHITE_Background (1) (2).png
Built On Hedera _ WHITE_Background (1) (3).png
Built On Hedera _ WHITE_Background (1).png
Built On Hedera _ WHITE_Background (2) (1).png
Built On Hedera _ WHITE_Background (2) (2).png
Built On Hedera _ WHITE_Background (2).png
Built On Hedera _ WHITE_Background (3).png
Built On Hedera _ WHITE_Background (4).png
Built On Hedera _ WHITE_Background (5).png
Built On Hedera _ WHITE_Background (6).png
Built On Hedera _ WHITE_Background.png
Built-On-Hedera-White (1).png
Built-On-Hedera-White.png
COINOMI.png
Cat-Hero-12-hero@2x-100_Exchanges_2022-12-07-020913_ugkr.webp
Consensus Service (1) (1) (1) (1).png
Consensus Service (1) (1) (1).png
Consensus Service (1) (1).png
Consensus Service2 (1).png
Consensus Service2.png
DER portal (1) (1) (1).png
DER portal (1) (1).png
DER portal (1).png
DER portal.png
Explorers.png
File Storage (1) (1) (1) (1).png
File Storage (1) (1) (1).png
File Storage (1) (1).png
GUARDA (1).png
GUARDA.png
HASHPACK.png
HH-Eco-Cat-Hero-Desktop-R1 (1) (1) (1) (1).webp
HH-Eco-Cat-Hero-Desktop-R1 (1) (1) (1) (2).webp
HH-Eco-Cat-Hero-Desktop-R1 (1) (1) (1).webp
HH-Eco-Cat-Hero-Desktop-R1 (1) (1).webp
HH-Eco-Hero-Desktop-R1.webp
Hero-Desktop-Council_2022-12-07-020253_rmzm (1) (1) (1).webp
Hero-Desktop-Council_2022-12-07-020253_rmzm (1) (1).webp
Hero-Desktop-Council_2022-12-07-020253_rmzm (1).webp
Hero-Desktop-EnterpriseApplications_2022-12-08-192047_ivzd (1) (1) (1) (1).webp
Hero-Desktop-EnterpriseApplications_2022-12-08-192047_ivzd (1) (1) (1) (2).webp
Hero-Desktop-EnterpriseApplications_2022-12-08-192047_ivzd (1) (1) (1).webp
Hero-Desktop-EnterpriseApplications_2022-12-08-192047_ivzd (1) (1).webp
Hero-Desktop-GrantsAccelerators_2022-12-07-020518_jikd.webp
Hero-Desktop-NetworkExplorers_2022-12-07-020704_ehza (1).webp
Hero-Desktop-NetworkExplorers_2022-12-07-020704_ehza.webp
Hero-Desktop-Tooling_2022-12-07-021130_ayix (1) (1) (1) (1) (1).webp
Hero-Desktop-Tooling_2022-12-07-021130_ayix (1) (1) (1) (1) (2).webp
Hero-Desktop-Tooling_2022-12-07-021130_ayix (1) (1) (1) (1).webp
Hero-Desktop-Tooling_2022-12-07-021130_ayix (1) (1) (1) (2).webp
Hero-Desktop-Tooling_2022-12-07-021130_ayix (2).webp
IMG_9444 (1) (1) (1) (1).jpg
IMG_9444 (1) (1) (1).jpg
IMG_9444 (1) (1).jpg
IMG_9453.jpg
Integrations.png
JSON (1).png
JSON-RPC relay Cloud computing_black.png
JSON-RPC relay.png
JSON.png
Network-topology (1) (1) (1) (1) (1) (1) (1) (1) (1).jpg
Network-topology (1) (1) (1) (1) (1) (1) (1) (1).jpg
Network-topology (1) (1) (1) (1) (1) (1) (1).jpg
Payments .png
Performance Measurement Results.jpeg
Performance Measurement Results_033.001 (1).png
Performance Measurement Results_033.001.png
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (2).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (1) (2).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1) (2).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1) (1).jpeg
Performance Measurement Results_Extract.001 (1) (1).jpeg
Performance Measurement Results_Extract.001 (2) (1).jpeg
Performance Measurement Results_Extract.001 (3) (1).jpeg
Performance Measurement Results_Extract.001 (3) (2).jpeg
Performance Measurement Results_Extract.001 (3).jpeg
Performance Measurement Results_Extract.001 (4).jpeg
Performance Measurement Results_Extract.001.jpeg
Performance Measurements.jpeg
SDKs.png
Screen Shot 2021-12-01 at 2.22.52 PM.png
Screen Shot 2021-12-01 at 2.26.12 PM (1).png
Screen Shot 2021-12-01 at 2.26.12 PM.png
Screen Shot 2021-12-01 at 2.28.09 PM.png
Screen Shot 2021-12-01 at 2.28.21 PM.png
Screen Shot 2022-10-03 at 11.18.08 AM.png
Screen Shot 2022-12-14 at 2.29.16 PM.png
Screen Shot 2022-12-14 at 2.29.51 PM.png
Screen Shot 2022-12-14 at 2.30.21 PM.png
Screen Shot 2022-12-14 at 2.31.24 PM.png
Screen Shot 2022-12-14 at 2.32.56 PM.png
Screen Shot 2023-05-08 at 4.45.33 PM.png
Screenshot 2022-12-15 at 8.02.55 AM.png
Screenshot 2022-12-15 at 8.04.27 AM.png
Screenshot 2022-12-19 at 11.25.23 PM.png
Screenshot 2022-12-19 at 11.27.08 PM.png
Screenshot 2022-12-19 at 11.28.43 PM.png
Screenshot 2022-12-19 at 11.42.24 PM.png
Screenshot 2022-12-19 at 11.43.17 PM.png
Screenshot 2022-12-19 at 11.43.59 PM.png
Screenshot 2022-12-19 at 11.44.55 PM (1).png
Screenshot 2022-12-19 at 11.44.55 PM.png
Screenshot 2022-12-19 at 11.46.52 PM.png
Screenshot 2022-12-19 at 11.47.35 PM.png
Screenshot 2022-12-20 at 2.39.29 PM (1).png
Screenshot 2022-12-20 at 2.39.29 PM.png
Screenshot 2022-12-20 at 3.11.05 PM.png
Screenshot 2022-12-20 at 3.17.17 PM.png
Screenshot 2023-01-24 at 8.28.08 AM.png
Screenshot 2023-01-24 at 8.47.32 AM.png
Screenshot 2023-02-16 at 3.05.30 PM.png
Screenshot 2023-03-06 at 11.24.23 AM.png
Security.png
Stability local node.png
Token Service (1).png
Untitled.png
WALLA (1).png
WALLA.png
_3223_v1_ultraviolet.jpg
accounts terminal.png
acoer dark.png
acoer.png
arkhia (1) (1) (1) (1).png
arkhia (1) (1) (1).png
arkhia (1) (1).png
arkhia logo.png
beta_mirror_node_1.png
betamirrornode-overview.jpg
black hedera.jpeg
case studies.png
case studies@4x.png
compiled success.png
consensus node.png
consensus service.png
contributing (1).jpeg
contributing 2.jpeg
contributing IMG_9447a_ultraviolet.jpeg
contributing.jpeg
core concepts.png
core concepts@4x.png
create & deploy a smart contract.png
create & deploy a smart contract@4x.png
create ECDSA account.png
create ECDSA.png
create an account.png
create an account@4x.png
create fungible tokens@4x.png
create non-fungible tokens@4x.png
decentralized-on-HH_black.jpg
decentralized-on-HH_white.jpg
dev tools.png
docker command up postgres.png
docker loca node.png
docker local node (1).png
docker local node (2).png
docker local node (3).png
docker local node (4).png
docker local node.png
docker ps (1).png
docker ps only db.png
docker ps.png
docs landing page icons (1).png
docs landing page icons (2).png
docs landing page icons.png
dot-NET-Standard-Logo-Square.webp
dragon glass.png
dragonglass dark.png
environment portal (1).png
environment portal (2).png
environment portal (3).png
environment portal.png
environment setup (1).png
environment setup.png
environment setup@4x.png
evm tools.png
example hardhat terminal.png
explorer new 2 (1).png
explorer new 2.png
file service (1).png
file service.png
file.excalidraw (1).svg
file.excalidraw.svg
fork repo.png
fungible tokens.png
gcs mirror2 (1).png
gcs mirror2.png
go sdk.png
gogo.png
graphql playground (1).png
graphql playground 3.png
graphql playground 4 (1).png
graphql playground 4.png
graphql playground.png
hardhat project setup (1).png
hardhat project setup.png
hashio (1).png
hashio.png
hashscan (1).png
hashscan explorer.png
hashscan testnet.png
hashscan.png
hcs_fabric.png
hedera explained.png
hedera explained@4x.png
hedera importer console.png
hedera network services.png
hex trust.png
hmac_keygen.gif
image (1) (1) (1) (1) (1) (1) (1) (1) (1) (1).png
image (1) (1) (1) (1) (1) (1) (1) (1) (1).png
image (1) (1).png
image (1).png
image (11).png
image (2) (1).png
image (2).png
image (3).png
image (4).png
image (5).png
image (6).png
image.png
image105 (1) (1) (1) (1) (1).png
image105 (1) (1) (1) (1).png
image105 (1) (1) (1).png
import accounts mm1.png
import accounts mm2.png
importer hedera console (1).png
importer hedera console.png
istockphoto-1407271723-170667a (1).jpg
istockphoto-1407271723-170667a.jpg
java black logo.png
java sdk.png
javascript sdk.png
js.png
ledgerworks-blue (1).png
ledgerworks-blue.png
libraries & tooling.png
libs & tooling Open source.png
libs & tooling Technology.png
list of relations s3 mirror (1).png
list of relations s3 mirror.png
local node (1).png
local node Hashgraph Classic.png
local node stability (1).png
local node stability (2).png
local node stability.png
local node terminal (1) (1) (1).png
local node terminal (1) (1).png
local node terminal (1).png
local node.png
magic link.png
meetups (1) (1) (1) (1).jpeg
meetups (1) (1) (1).jpeg
meetups (1) (1).jpeg
metamask-fox-logo.webp
mirror explorer link (1).jpeg
mirror explorer link.jpeg
mirror node alt.png
mirror node contract ID
mirror node contract ID (1)
mirror node contract ID (2)
mirror node contract ID (3)
mirror node explorer.png
mirror node.png
monitor & security.png
myhbarwallet.png
network b (1).png
network b.png
network bridge (1).png
network bridge.png
network bridger.png
network brirdge.png
network explorers.png
network-topology (1).jpg
network-topology.jpg
new hashscan (1).png
new hashscan (2).png
new hashscan.png
new portal 2 (1).png
new portal 2 (2).png
new portal 2.png
new portal keys (1).jpeg
new portal keys.jpeg
node explorer (1).png
node explorer.png
non-fungible tokens.png
npx hardhat compile (1).png
npx hardhat compile.png
okx.png
one click mirror node.png
portal ecdsa.jpeg
portal hex copy 2.png
portal hex.png
portal screenshot (1) (1) (1) (1).png
portal screenshot (1) (1) (1) (2).png
portal screenshot (1) (1) (1).png
portal screenshot (1) (1) (2).png
portal screenshot.avif
portal testnet account.png
portal.png
project_directory (1) (1).png
project_directory (1).png
project_directory.png
purple hbar.png
query-confirmation.png
r3.jpg
r4.jpg
security v2.png
setup metamask.png
smart contracts.png
startblock.png
subgraph structure.png
swift logo.png
swift-programming-logo.jpg
terminal docker compose  (1).png
terminal docker compose .png
test.png
testnet access (1).png
testnet access (2).png
testnet access.png
testnet access@4x.png
testnet.png
token - layered.png
token 2.png
token service.png
transaction-flow.png
transaction_records_1.png
transaction_records_2.png
transaction_records_3.png
transaction_records_4.png
transaction_records_5.png
transaction_records_6.png
transaction_records_7.png
transfer hbar.png
transfer hbar@4x.png
uphold (1).png
uphold.png
violet hbar.png
wallet integrations.png
why hedera.png
why hedera@4x.png
write verifiable data to hedera@4x.png
write verifiable data.png
yamgo.png

Additional context

NIL

Hedera network

other

Version

commit 494681a8981f83fe75e87f5040299362c2d66ed3 of this repo

Operating system

macOS

### Tasks
- [ ] Create standard for GitBook asset naming convention
ElijahLynn commented 9 months ago

I just switched from a previous branch to master and did a git pull and it said there was an abort due to existing files and I can't get rid of them. I've tried a git restore, git reset --hard, git checkout, git clean .

~/p/hedera-docs (patch-6|✚3)
 git ch master
M   .gitbook/assets/Smart Contracts (1).png
M   .gitbook/assets/Smart Contracts.png
M   .gitbook/assets/Token Service.png
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

 ~/p/hedera-docs (master|✚3)
 git pull
remote: Enumerating objects: 540, done.
remote: Counting objects: 100% (537/537), done.
remote: Compressing objects: 100% (300/300), done.
remote: Total 540 (delta 275), reused 487 (delta 237), pack-reused 3
Receiving objects: 100% (540/540), 13.24 MiB | 2.71 MiB/s, done.
Resolving deltas: 100% (275/275), completed with 4 local objects.
From https://github.com/hashgraph/hedera-docs
   5ff89a0..76d85d8  master     -> origin/master
 * [new branch]      staging    -> origin/staging
Updating 5ff89a0..76d85d8
error: Your local changes to the following files would be overwritten by merge:
    .gitbook/assets/Smart Contracts (1).png
    .gitbook/assets/Smart Contracts.png
Please commit your changes or stash them before you merge.
Aborting

~/p/hedera-docs (master↓66|✚3)
 git status
On branch master
Your branch is behind 'origin/master' by 66 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .gitbook/assets/Smart Contracts (1).png
    modified:   .gitbook/assets/Smart Contracts.png
    modified:   .gitbook/assets/Token Service.png

no changes added to commit (use "git add" and/or "git commit -a")
a-ridley commented 7 months ago

@ElijahLynn I have a mac and MacOs is a case-insensitive file system. I was trying to do the DCO rebase sign-off command and was blocked saying there were changes (with those images you pointed out above) and I couldn't get passed it at all. Therefore, I ended up having to create a case-sensitive file system following https://docs.spryker.com/docs/scos/dev/tutorials-and-howtos/howtos/howto-handle-case-sensitive-file-system-on-mac-os.html#create-the-disk-image. It was not a smooth process but it unblocked me.

bguiz commented 7 months ago

I've just done a fresh git clone, and the following warnings are output:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  '.gitbook/assets/Network-topology.jpg'
  '.gitbook/assets/network-topology.jpg'
  '.gitbook/assets/Smart Contracts.png'
  '.gitbook/assets/smart contracts.png'
bguiz commented 7 months ago

And immediately after the git clone:

user@admins-MBP hedera-docs % git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .gitbook/assets/Smart Contracts.png

no changes added to commit (use "git add" and/or "git commit -a")
user@admins-MBP hedera-docs % git restore .gitbook/assets/Smart\ Contracts.png 
user@admins-MBP hedera-docs % git status                                      
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .gitbook/assets/smart contracts.png

no changes added to commit (use "git add" and/or "git commit -a")
user@admins-MBP hedera-docs % git restore .gitbook/assets/smart\ contracts.png 
user@admins-MBP hedera-docs % git status                                      
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .gitbook/assets/Smart Contracts.png

no changes added to commit (use "git add" and/or "git commit -a")

(cycles indefinitely)

theekrystallee commented 7 months ago

I'm not sure what you're getting at here. This issue/ticket is not complete/has not been resolved 100% yet

bguiz commented 7 months ago

I'm not sure what you're getting at here. This issue/ticket is not complete/has not been resolved 100% yet

ElijahLynn commented 6 months ago

I'm not sure what is going on here just yet, but for me, 4 files keep showing up, so I made a PR to get them to not show anymore. 

 git pull
Updating 7be3b3e..0de25bd
error: Your local changes to the following files would be overwritten by merge:
    .gitbook/assets/Consensus Service.png
    .gitbook/assets/Smart Contracts (1).png
    .gitbook/assets/Token Service.png
Please commit your changes or stash them before you merge.
Aborting

git stash
Saved working directory and index state WIP on master: 7be3b3e GITBOOK-2483: No subject

git status
On branch master
Your branch is behind 'origin/master' by 42 commits, and can be fast-forwarded.
  (use "git pull" to update your local branch)

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   .gitbook/assets/consensus service.png
    modified:   .gitbook/assets/smart contracts (1).png
    modified:   .gitbook/assets/smart contracts.png
    modified:   .gitbook/assets/token service.png

https://github.com/hashgraph/hedera-docs/pull/597

I feel like we need to do a working session to resolve this.

a-ridley commented 6 months ago

@ElijahLynn I agree, this has been a big friction point in contributing to docs for me and I feel this task should be prioritized.

We need to remove any duplicate file names where the difference is only the casing.

For example, token service.png and Token Service.png one of these should be deleted and the remaining file will need to be renamed to adhere to the standard naming convention token-service.png.

This task will be easier to complete on a windows machine as macOS is case-insensitive.

I've also requested the addition of a pre-commit hook to prevent further challenges in the future.

theekrystallee commented 6 months ago

@ElijahLynn those files are not in the assets directory, so I am not sure why they are showing up.

@a-ridley I understand it's a friction point but this is a larger job than just deleting duplicate file names. We have to go page by page on docs.hedera.com to ensure we are deleting a file that is LIVE on the site. I learned this the hard way when I did attempt your suggested solution, which left some of the docs pages without images.

Unfortunately, this is not something I can prioritize over other issues at the moment but if you'd like to help by contributing, that'd be great.

a-ridley commented 6 months ago

@theekrystallee Here is a PR to address the issue of removing the duplicated files. https://github.com/hashgraph/hedera-docs/pull/598

Updated: The rest of the task to rename all files to meet naming conventions can wait as that is not impacting development :)

cc @ElijahLynn Two of those files you mentioned are not present (the others are present) and it may be due to your fork of the repository. The PR I've created should address you issue once it's merged in. If it doesn't, you may have to delete and fork again

theekrystallee commented 6 months ago

@a-ridley thank you!! I initially thought you submitted a fix for all files and couldn't believe how quickly you turned that around 😅