hashgraph / hedera-json-rpc-relay

Implementation of Ethereum JSON-RPC APIs for Hedera
Apache License 2.0
63 stars 70 forks source link

Add redis to relay helm chart as a dependency #1870

Open georgi-l95 opened 1 year ago

georgi-l95 commented 1 year ago

πŸ†•πŸ₯ First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hedera.

πŸ‘Ύ Description of the issue

Currently the relay helm chart does not include redis.

Proposed Solution:

Add redis to the helm chart as a dependency.

Example Implementation

apiVersion: v2
name: my-app
description: A Helm chart for my application that depends on Redis
version: 0.1.0
appVersion: "1.0"

dependencies:
  - name: redis
    version: "17.3.14"     # Use the version compatible with your Helm and Redis needs
    repository: "https://charts.bitnami.com/bitnami"

πŸ“‹ Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file. A more detailed general documentation of the GitHub PR workflow can be found here.

πŸŽ‰ Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

πŸ€” Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

SanchitMahajan236 commented 2 weeks ago

Please assign me this issue. I would love to contribute.

AlfredoG87 commented 2 weeks ago

@SanchitMahajan236

Id suggest that as part of the PR, the operator can choose to deploy with or without redis by using a enable value. Also, if they choose to enable redis, that the Relay uses the correct configuration as to use it.

take a look at the configuration document for more information: properties: REDIS_ENABLED and REDIS_URL should be correctly set depending on your feature flag.