search

hashgraph / hedera-json-rpc-relay

Implementation of Ethereum JSON-RPC APIs for Hedera
Apache License 2.0
68 stars 72 forks source link

Hanging or No Response Error for Succeeding Contract Deployment via CREATE2 #2639

Open mgarbs opened 4 months ago

mgarbs commented 4 months ago

Description

When deploying a contract via CREATE2 using the relay, the contract is successfully deployed on the network. However, the frontend/sdk level RPC response either hangs or returns an error, despite the transaction succeeding.

Example:

Example transaction: Hashscan Transaction Thirdweb Dashboard Import: Thirdweb Contract

Steps to reproduce

Steps to Reproduce:

Deploy a contract via CREATE2 using the JSON-RPC. Observe the frontend/sdk level response. Expected Behavior: The RPC response should correctly indicate the success of the transaction.

Behavior: The RPC response hangs or returns an error despite the transaction succeeding on the network.

Additional Information:

The issue has been observed with deployments via a CREATE2 factory. Screenshot of the error is attached under additional context.

Additional context

image

Hedera network

mainnet

Version

v.50

Operating system

macOS

Nana-EC commented 4 months ago

Thanks @mgarbs Was their a request-id in the logs?

Additionally, can ThirdWeb verify their contract to help with troubleshooting - https://hashscan.io/mainnet/contract/0.0.6277432 Or can they provide a smaller contract and client code to help repro? Thanks

kumaryash90 commented 4 months ago

Thanks @mgarbs @Nana-EC

I can try verifying the contract. What's the explorer / api for verification? Does it accept solidity standard json?

Meanwhile, also linking here the deployed contract source code (thirdweb dashboard): https://thirdweb.com/hedera/0x529E71f9A6044da2A0A6480bE5C0475E2A63b7f6/sources

Nana-EC commented 4 months ago

Thanks @mgarbs @Nana-EC

I can try verifying the contract. What's the explorer / api for verification? Does it accept solidity standard json?

Meanwhile, also linking here the deployed contract source code (thirdweb dashboard): https://thirdweb.com/hedera/0x529E71f9A6044da2A0A6480bE5C0475E2A63b7f6/sources

Hey @kumaryash90 , you can verify via the explore as follows https://docs.hedera.com/hedera/tutorials/smart-contracts/how-to-verify-a-smart-contract-on-hashscan

victor-yanev commented 4 months ago

Hi @mgarbs, I tried reproducing the error by deploying the same Airdrop.sol smart contract using CREATE2, but it succeeds both locally and on testnet.

https://hashscan.io/testnet/transaction/1720513105.344333003

I'd be happy if you could give more details on how you produced this error.