search

hashgraph / hedera-json-rpc-relay

Implementation of Ethereum JSON-RPC APIs for Hedera
Apache License 2.0
68 stars 72 forks source link

ci: Updating permissions within manual-testing to resolve workflow issue. #3019

Closed san-est closed 2 months ago

san-est commented 2 months ago

Description: There is an issue in the manual-testing workflow file, the acceptance workflow requires actions: read permissions but its not getting them when manual testing is ran. Initially I thought they were not defined in the acceptance workflow file but everything seems to be fine there so adding permissions here.

Related issue(s):

Fixes #3017

Notes for reviewer:

Checklist

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

Tests

       3 files     297 suites   19s :stopwatch: 1 353 tests 1 352 :heavy_check_mark: 1 :zzz: 0 :x: 1 362 runs  1 361 :heavy_check_mark: 1 :zzz: 0 :x:

Results for commit 364479ed.

github-actions[bot] commented 2 months ago

Acceptance Tests

  18 files  246 suites   30m 28s :stopwatch: 609 tests 598 :heavy_check_mark: 4 :zzz: 7 :x: 691 runs  680 :heavy_check_mark: 4 :zzz: 7 :x:

Results for commit 364479ed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.93%. Comparing base (f6f1220) to head (364479e). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3019 +/- ## ========================================== + Coverage 89.92% 89.93% +0.01% ========================================== Files 58 61 +3 Lines 3900 4053 +153 Branches 780 815 +35 ========================================== + Hits 3507 3645 +138 - Misses 346 358 +12 - Partials 47 50 +3 ``` | [Flag](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [relay](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `90.14% <ø> (-0.01%)` | :arrow_down: | | [server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `88.15% <ø> (ø)` | | | [ws-server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#carryforward-flags-in-the-pull-request-comment) to find out more. [see 10 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3019/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)