hashgraph / hedera-json-rpc-relay

Implementation of Ethereum JSON-RPC APIs for Hedera
Apache License 2.0
68 stars 72 forks source link

fix: failing websocket tests in manual-testing.yml #3027

Closed victor-yanev closed 1 month ago

victor-yanev commented 1 month ago

Description:

Currently, the manual-testing.yml workflow has regressions in its configurations which causes some of the web-socket server acceptance tests to fail when ran through the Manual Testing job in GitHub.

This PR fixes those failing tests.

Related issue(s):

Fixes #3028

Notes for reviewer:

Checklist

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 month ago

Acceptance Tests

  18 files  229 suites   29m 59s :stopwatch: 606 tests 599 :heavy_check_mark: 4 :zzz: 3 :x: 683 runs  675 :heavy_check_mark: 5 :zzz: 3 :x:

Results for commit 590a4702.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.91%. Comparing base (b4fc617) to head (590a470). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3027 +/- ## ======================================= Coverage 89.91% 89.91% ======================================= Files 58 58 Lines 3905 3905 Branches 784 784 ======================================= Hits 3511 3511 Misses 347 347 Partials 47 47 ``` | [Flag](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3027/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [relay](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `90.12% <ø> (ø)` | | | [server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `88.15% <ø> (ø)` | | | [ws-server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#carryforward-flags-in-the-pull-request-comment) to find out more.