Closed victor-yanev closed 1 month ago
A potential memory leak has been detected in the test titled should execute "eth_getTransactionByHash with missing transaction"
. This may impact the application's performance and stability.
📊 Memory Leak Detection Report 📊
GC Type: MarkSweepCompact Cost: 27,761.2 ms
Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.
3 files 297 suites 19s :stopwatch: 1 353 tests 1 352 :heavy_check_mark: 1 :zzz: 0 :x: 1 362 runs 1 361 :heavy_check_mark: 1 :zzz: 0 :x:
Results for commit 9cd8081e.
:recycle: This comment has been updated with latest results.
16 files 214 suites 29m 12s :stopwatch: 602 tests 598 :heavy_check_mark: 4 :zzz: 0 :x: 618 runs 614 :heavy_check_mark: 4 :zzz: 0 :x:
Results for commit 9cd8081e.
:recycle: This comment has been updated with latest results.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
After discussing this with xin, it seems like those changes were not needed
Attention: Patch coverage is 83.33333%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 84.02%. Comparing base (
f1794d8
) to head (9cd8081
).
Files with missing lines | Patch % | Lines |
---|---|---|
packages/relay/src/lib/clients/mirrorNodeClient.ts | 75.00% | 0 Missing and 1 partial :warning: |
Description:
MirrorNodeClient
:getAccount
method to optionally accept aITimestampParams
parameterprepareLogsParams
,getContractResultsLogs
andgetContractResultsLogsByAddress
with strong typing on theparams
object that they accept - it now uses theIContractLogsResultsParams
interface and this helps us track exactly where those methods are called and with which params passed to themeth_getBlockByHash
andeth_getBlockByNumber
to pass a timestamp range from the fetched block to subsequent calls togetLogsWithParams
Related issue(s):
Fixes #3040
Notes for reviewer:
Checklist