search

hashgraph / hedera-json-rpc-relay

Implementation of Ethereum JSON-RPC APIs for Hedera
Apache License 2.0
68 stars 72 forks source link

feat: add additional tests for unexpected fail appends failures during contract creation via `eth_sendRawTransaction` #3139

Closed natanasow closed 3 weeks ago

natanasow commented 4 weeks ago

Description:

Add additional tests for the handling of the failure of a random transaction from all of the executed FileAppend transactions when the callData is large in eth_sendRawTransaction

Related issue(s):

Fixes #2711

Notes for reviewer:

Checklist

github-actions[bot] commented 4 weeks ago

Tests

       4 files     404 suites   18s :stopwatch: 1 431 tests 1 430 :heavy_check_mark: 1 :zzz: 0 :x: 1 440 runs  1 439 :heavy_check_mark: 1 :zzz: 0 :x:

Results for commit f039005b.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 4 weeks ago

Acceptance Tests

  17 files  228 suites   31m 31s :stopwatch: 599 tests 593 :heavy_check_mark: 4 :zzz: 2 :x: 623 runs  617 :heavy_check_mark: 4 :zzz: 2 :x:

Results for commit f039005b.

:recycle: This comment has been updated with latest results.

sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.27%. Comparing base (4ab3666) to head (f039005). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3139 +/- ## ========================================== + Coverage 83.20% 83.27% +0.07% ========================================== Files 66 66 Lines 4250 4250 Branches 828 828 ========================================== + Hits 3536 3539 +3 + Misses 472 471 -1 + Partials 242 240 -2 ``` | [Flag](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | Coverage Δ | | |---|---|---| | [config-service](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `100.00% <ø> (ø)` | | | [relay](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `85.45% <ø> (+0.08%)` | :arrow_up: | | [server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `83.52% <ø> (ø)` | | | [ws-server](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph) | `36.87% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/hashgraph/hedera-json-rpc-relay/pull/3139/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hashgraph)