Closed natanasow closed 2 weeks ago
A potential memory leak has been detected in the test titled validates enforcement of request id
. This may impact the application's performance and stability.
π Memory Leak Detection Report π
GC Type: MarkSweepCompact Cost: 30,549.4 ms
Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
Old Space:
Large Object Space:
Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.
β17 filesβ β-βββ3ββ229 suitesβ β-β42βββ28m 51s :stopwatch: - 11m 43s 603 tests β-βββ1ββ599 :white_check_mark: +ββ4ββ4 :zzz: Β±0ββ0 :x: β-β5β 619 runsβ β-β114ββ615 :white_check_mark: β-β108ββ4 :zzz: β-β1ββ0 :x: β-β5β
Results for commit a41beb1b.βΒ± Comparison against base commit 7fea98c0.
:recycle: This comment has been updated with latest results.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.80%. Comparing base (
7fea98c
) to head (a41beb1
). Report is 34 commits behind head on main.
π¨ Try these New Features:
Description:
Currently, there are transactions that hadn't entered the evm (reverted due to hedera-specific validations) but are included in a generated record file, also they are imported in the mirror node db. These transactions must be excluded from the response to block-related routes.
Solutions:
We should hook in here https://github.com/hashgraph/hedera-json-rpc-relay/pull/3158/files#diff-dd8c7990f7764960d05dcb4c1b5ae7eee48b425b1b83d6dcc7e7ccc442330ef0R2303 and add a type for
INVALID_ACCOUNT_ID
as well.These checks must be defined as an environment variable (as an array) and we could be able easily to add/remove transaction statuses.
Related issue(s):
Fixes #3171
Notes for reviewer:
Checklist