search

hashgraph / hedera-metamask-snaps

Metamask snaps offer the ability to create npm package that can be used to enhance the wallet capabilities for chains and DApps.
Apache License 2.0
7 stars 1 forks source link

Fix PR workflow check for dependabot updates #791

Closed mishomihov00 closed 5 days ago

mishomihov00 commented 1 week ago

Description

When dependabot creates a new PR the wallet-snap-analyze job from the flow-pull-request-checks.yaml workflow is skipped because of the if statement which is configured to skip the job if the PR is coming from dependabot, but this job is required for PR merging which leads to a "deadlock" and the inability to merge dependabot PR's.

Steps to reproduce

Wait for dependabot to create a PR and look at the checks.

Additional context

Example PR's:

789

790

Hedera network

No response

Version

latest

Operating system

None

mishomihov00 commented 1 week ago

@hashgraph/devops-ci another possible solution to this problem is just to remove the "Required" field for this job. If you think doing that is better, please feel free to discard this ticket and the PR.

rbarkerSL commented 5 days ago

We should keep the dependabot check in here and force the repository owners to merge these bumps coming from dependabot.

mishomihov00 commented 5 days ago

@rbarkerSL understood. Closing the PR and the issue.