fix: duplication of 'limit' query parameter in axios calls located inside a loop.

hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.

Apache License 2.0

14 stars 9 forks source link

fix: duplication of 'limit' query parameter in axios calls located inside a loop. #1041

Closed svienot closed 2 months ago

svienot commented 2 months ago

Description:

Almost everything is in the title. We also bump the limit to 100 in these calls to reduce the number of calls to mirror-node since the goal is to get an exhaustive list of entities.

Notes for reviewer:

Fix can be observed on mainnet contract: 0.0.5060536

sonarcloud[bot] commented 2 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 2 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	83.09%	39036 / 46980
🔵	Statements	83.09%	39036 / 46980
🔵	Functions	63.02%	888 / 1409
🔵	Branches	84.34%	4084 / 4842

File Coverage

File	Stmts	% Branch	% Funcs	% Lines
Changed Files
src/utils/cache/NetworkCache.ts	100%	88.88%	100%	100%
src/utils/cache/NftCollectionCache.ts	100%	84.21%	100%	100%

Generated in workflow #874