chore: BalanceAnalyzer now extends EntityLoaderV2.

hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.

Apache License 2.0

14 stars 9 forks source link

chore: BalanceAnalyzer now extends EntityLoaderV2. #1062

Closed ericleponner closed 2 months ago

ericleponner commented 2 months ago

Description:

BalanceAnalyzer now extends EntityLoaderV2. Theses changes do not change semantic but should fix random breaking observed when unit tests are executed by GitHub.

ReferenceError: window is not defined > BalanceAnalyzer.scheduleNextLookup src/utils/analyzer/BalanceAnalyzer.ts:105:9 > BalanceAnalyzer.accountIdDidChange src/utils/analyzer/BalanceAnalyzer.ts:95:22

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

github-actions[bot] commented 2 months ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	82.9%	38809 / 46813
🔵	Statements	82.9%	38809 / 46813
🔵	Functions	62.62%	873 / 1394
🔵	Branches	84.06%	4063 / 4833

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/utils/analyzer/BalanceAnalyzer.ts	100%	100%	100%	100%

Generated in workflow #916

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud