search

hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.
Apache License 2.0
14 stars 9 forks source link

feat: allow user to navigate to account NFT collection #1063

Closed svienot closed 2 months ago

svienot commented 2 months ago

Description:

Allow the user, when clicking an NFT balance in the AccountDetails view, to navigate to the NFT collection for that account -- i.e. the table listing all serial numbers owned by that account for that NFT collection.

Also include minor UI adjustments around the display of NFTs.

Related issue(s):

Fixes #1046

Notes for reviewer:

See screen captures. This is not deployed on staging server.

Screenshot 2024-05-28 at 12 26 49 Screenshot 2024-05-28 at 12 29 30 Screenshot 2024-05-28 at 12 30 00
github-actions[bot] commented 2 months ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.92% 38850 / 46850
🔵 Statements 82.92% 38850 / 46850
🔵 Functions 62.71% 873 / 1392
🔵 Branches 84.02% 4060 / 4832
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/account/CollectionTable.vue 75% 100% 0% 75% 86-117
src/components/account/NftsTable.vue 96.63% 80% 50% 96.63% 96-99
src/components/allowances/ApproveAllowanceDialog.vue 45.66% 55.26% 5.4% 45.66% 53-56, 100-108, 110-113, 135-143, 145-148, 167-169, 190, 287-291, 296-297, 310-311, 318, 332-346, 350-363, 368-371, 375-410, 414-424, 430-440, 443-447, 450-460, 463-467, 470-480, 483-488, 500-502, 504-527, 547-548, 551-553, 556-620, 623-656, 659-682, 685-710, 713-744, 747-793, 796-846, 849-865
src/components/values/InlineBalancesValue.vue 92.2% 85% 100% 92.2% 99-106, 132-135
src/components/values/TokenAmount.vue 99.41% 86.84% 100% 99.41% 144
src/components/values/link/TokenExtra.vue 98.03% 85.71% 100% 98.03% 72, 77
src/pages/AccountBalances.vue 100% 75% 100% 100%
src/pages/AccountCollection.vue 72% 100% 0% 72% 104-145
src/pages/AccountDetails.vue 45.84% 82.22% 14.28% 45.84% 1-276, 391-397, 401-403, 441-442, 447-448, 465-467
src/pages/NftDetails.vue 66.95% 100% 0% 66.95% 215-318, 321-329
src/pages/TokenDetails.vue 99.01% 96.77% 66.66% 99.01% 422, 435-436, 489-490
src/schemas/HederaUtils.ts 79.56% 73.23% 80% 79.56% 41-43, 49-50, 58-59, 66-67, 74-75, 84-85, 103-104, 114-117, 127-130, 135-136, 178-187, 189-190, 196-197, 240-248, 257-265, 268-276
Generated in workflow #919
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud