hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.
Apache License 2.0
14 stars 9 forks source link

Fix: use ascending order in token tables #1074

Closed svienot closed 1 month ago

svienot commented 1 month ago

Description:

Other (unrelated) fixes:

Notes for reviewer:

Changes visible on staging server, although mixed to more substantial NFT changes.

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.8% 39060 / 47170
🔵 Statements 82.8% 39060 / 47170
🔵 Functions 62.98% 885 / 1405
🔵 Branches 84.07% 4071 / 4842
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/account/CollectionTableController.ts 31.03% 100% 0% 31.03% 28-87
src/components/token/NftHolderTableController.ts 90% 75% 57.14% 90% 57-58, 70-71, 74-75, 78-79
src/components/token/TokenBalanceTableController.ts 90% 75% 57.14% 90% 57-58, 70-71, 74-75, 78-79
src/components/values/TokenAmount.vue 99.41% 86.84% 100% 99.41% 144
src/pages/AccountCollection.vue 71.15% 100% 0% 71.15% 107-151
src/pages/TokenDetails.vue 99.01% 96.77% 66.66% 99.01% 422, 435-436, 489-490
Generated in workflow #930
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud