hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.
Apache License 2.0
14 stars 9 forks source link

feat: display topic details using `/api/v1/topics/{id}` call #1083

Closed svienot closed 1 month ago

svienot commented 1 month ago

Description:

Leverage the new mirror-node /api/v1/topics/{id} REST API to display topic details. The 3 properties mandatory in the API result are always displayed: Memo, Valid from and Valid until. The other (nullable) properties are shown only when their value is non null.

Related issue(s):

Fixes #713

Notes for reviewer:

API available only on previewnet for the time being.

Deployed on staging server.

Checklist

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.86% 39231 / 47345
🔵 Statements 82.86% 39231 / 47345
🔵 Functions 63.06% 888 / 1408
🔵 Branches 84.07% 4101 / 4878
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/TopicDetails.vue 99.17% 88.67% 100% 99.17% 195, 197
src/schemas/HederaSchemas.ts 96.41% 64.28% 87.5% 96.41% 111-125, 314-315, 734, 860-861, 863-864, 880-881, 883-890
src/utils/cache/TopicByIdCache.ts 96.61% 83.33% 100% 96.61% 54-55
Generated in workflow #941
sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

svienot commented 1 month ago

Closing this PR since it is stuck by the DCO check. Will re-open a clone of this one.