fix: `Call Trace` entries contain the same parameters for each call

hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.

Apache License 2.0

14 stars 9 forks source link

fix: `Call Trace` entries contain the same parameters for each call #1122

Closed ericleponner closed 2 weeks ago

ericleponner commented 3 weeks ago

Description:

This is a regression introduced in #1000. Change below restore (wrongly removed) ContractActionAnalyzer class and add unit tests to avoid regression.

Related issue(s):

Fixes #1117

Notes for reviewer:

Use 1718213391.883698003 to see fix in action. See #1117 for additional details.

Fix is deployed on staging server.

Checklist

[ ] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

sonarcloud[bot] commented 3 weeks ago

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
41.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

github-actions[bot] commented 3 weeks ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	83.06%	40131 / 48313
🔵	Statements	83.06%	40131 / 48313
🔵	Functions	62.76%	902 / 1437
🔵	Branches	84.07%	4192 / 4986

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/contract/ContractActionDetails.vue	88.5%	100%	0%	88.5%	145-164
src/utils/analyzer/ContractActionAnalyzer.ts	96.85%	83.33%	100%	96.85%	78-79, 99-100

Generated in workflow #1009