hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.
Apache License 2.0
14 stars 9 forks source link

chore: pass network as parameter to SearchRequest constructor #1134

Closed ericleponner closed 2 weeks ago

ericleponner commented 2 weeks ago

Description:

Changes below refactor SearchRequest class. They don't include any semantic changes.

SearchRequest is now pass current network as a constructor parameter. This will ease some upcoming unit tests with multiple networks.

Checklist

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.06% 40127 / 48309
🔵 Statements 83.06% 40127 / 48309
🔵 Functions 62.76% 902 / 1437
🔵 Branches 84.06% 4190 / 4984
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/SearchBar.vue 53.52% 50% 14.28% 53.52% 28-40, 47, 59-60, 104-105, 107-120, 123-200, 203, 213
src/utils/SearchRequest.ts 87.43% 79.72% 92.3% 87.43% 124-129, 141-142, 163-166, 195-197, 203-204, 224-225, 307-310, 341-344, 346-353, 358-359, 364-373
Generated in workflow #1019
sonarcloud[bot] commented 2 weeks ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
20.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud