hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.
Apache License 2.0
16 stars 12 forks source link

chore: explorer now uses `api/v1/topics/{topicId}` for all networks #1137

Closed ericleponner closed 3 months ago

ericleponner commented 3 months ago

Description:

Changes below are a follow-up of #1087 and #1136. They 1) remove compatibility code from TopicDetails vue and SearchRequest class 2) re-activate "should flag deleted topic" test in TopicDetails unit tests 3) add missing TopicIdCache.instance.clear() in CacheUtils.clearAll() 4) remove some unneeded call from TopicIdCache.load()

Checklist

github-actions[bot] commented 3 months ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.05% 40130 / 48315
🔵 Statements 83.05% 40130 / 48315
🔵 Functions 62.7% 901 / 1437
🔵 Branches 84.08% 4183 / 4975
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/SearchBar.vue 53.52% 50% 14.28% 53.52% 28-40, 47, 59-60, 104-105, 107-120, 123-200, 203, 213
src/pages/TopicDetails.vue 100% 92.45% 100% 100%
src/utils/SearchRequest.ts 87.46% 79.72% 92.3% 87.46% 125-130, 142-143, 164-167, 196-198, 204-205, 227-228, 308-311, 342-345, 347-354, 359-360, 365-374
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
src/utils/cache/TopicByIdCache.ts 87.93% 75% 66.66% 87.93% 34-38, 53-54
Generated in workflow #1028
sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud