chore: refactor allowance approval dialog

hashgraph / hedera-mirror-node-explorer

Hedera Mirror Node Explorer for the Hedera Hashgraph DLT.

Apache License 2.0

14 stars 9 forks source link

Closed svienot closed 2 weeks ago

svienot commented 2 weeks ago

Description:

Refactoring and fixing of the ApproveAllowanceDialog. The AccountDetails sections are renamed:

github-actions[bot] commented 2 weeks ago

Status	Category	Percentage	Covered / Total
🔵	Lines	83.03%	40160 / 48366
🔵	Statements	83.03%	40160 / 48366
🔵	Functions	62.74%	901 / 1436
🔵	Branches	84.1%	4192 / 4984

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/allowances/ApproveAllowanceDialog.vue	51.73%	57.5%	6.45%	51.73%	53-56, 100-108, 110-113, 135-143, 145-148, 167-169, 190, 282-286, 291-292, 305-316, 326-327, 335, 349-363, 367-380, 385-388, 393-428, 432-442, 446-462, 465-475, 479-498, 501-513, 517-536, 539-549, 553-560, 572-574, 576-603, 616-621, 623-628, 630-635, 637-642, 644-649, 651-656, 659-660, 663-665, 668-732, 735-751
src/pages/AccountDetails.vue	46.92%	81.91%	14.28%	46.92%	1-285, 405-411, 415-417, 455-456, 461-462, 479-481
src/schemas/HederaUtils.ts	69.68%	73.23%	74.07%	69.68%	44-46, 52-53, 61-62, 69-70, 77-78, 87-88, 106-107, 117-120, 130-133, 138-139, 181-190, 192-193, 199-200, 243-251, 260-268, 271-279, 328-343, 345-376
src/utils/InputUtils.ts	25%	100%	0%	25%	25-58, 61-84, 87-112

Generated in workflow #1031

sonarcloud[bot] commented 2 weeks ago

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)