hashgraph / hedera-mirror-node

Hedera Mirror Node archives data from consensus nodes and serves it via an API
Apache License 2.0
117 stars 109 forks source link

Rest API redis error: wrong number of arguments for 'mget' command #8606

Closed jascks closed 1 week ago

jascks commented 1 week ago

Description:

It appears the following redis error happens quite frequently in testnet:

2024-06-18T19:40:31.232Z WARN e2b77dc8 Redis error during mget: ERR wrong number of arguments for 'mget' command
2024-06-18T19:40:31.233Z WARN e2b77dc8 x.x.x.x GET /api/v1/accounts/0.0.5897416?&limit=999 in 40 ms: 404 Not found NotFoundError Not found

If the keys provided to mget(), mgetBuffer() etc are empty, then the behavior is to throw this error. There are a few opportunities for transactions.getTransactionTimestamps() to return empty rows. It seems reasonable for cache.get() to look for this condition.

Related issue(s):

Fixes #8587

Notes for reviewer:

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.40%. Comparing base (9e53c18) to head (3ed6551). Report is 15 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8606 +/- ## ============================================ - Coverage 92.52% 92.40% -0.13% - Complexity 7372 7489 +117 ============================================ Files 895 914 +19 Lines 29553 29856 +303 Branches 3610 3641 +31 ============================================ + Hits 27345 27588 +243 - Misses 1387 1442 +55 - Partials 821 826 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud