hashgraph / hedera-mirror-node

Hedera Mirror Node archives data from consensus nodes and serves it via an API
Apache License 2.0
117 stars 110 forks source link

Fix value of v in contract result APIs for legacy Ethereum transactions #8632

Closed steven-sheehy closed 6 days ago

steven-sheehy commented 6 days ago

Description:

Fix the return value of v in the contract results APIs to use the actual signature_v field instead of recovery_id for legacy Ethereum transactions.

Related issue(s):

Fixes #8597

Notes for reviewer:

Checklist

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.40%. Comparing base (035e078) to head (1850a64). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8632 +/- ## ============================================ + Coverage 92.39% 92.40% +0.01% Complexity 7489 7489 ============================================ Files 914 914 Lines 29856 29860 +4 Branches 3641 3644 +3 ============================================ + Hits 27585 27592 +7 + Misses 1445 1442 -3 Partials 826 826 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.