Currently the way that the contractActionIndexOfCurrentFrame is tracked inside OpcodeTracer is not exactly how it is done in the HederaTracer, where the list of contract actions is built and we are still using the mono code in the web3 module, so we need to refactor this to be identical to what is done in HederaTracer. We need to copy the logic from there and increment the contractActionIndexOfCurrentFrame in the places where items are pushed to the allActions list in HederaTracer.
Solution
Copy the way contract actions are added to the allActions list in HederaTracer
Looks like actions are generated in init, tracePrecompileResult, traceAccountCreationResult, and tracePostExecution
And also copy the needed logic from CustomMessageCallProcessor, which handles the precompile calls, updates the state of the message frames, sets an exceptional halt reason and also calls the tracePrecompileResult method from the HederaOperationTracer interface.
Test that there are no regressions in the eth_call, eth_estimateGas and debug_traceTransaction methods
Verify that OpcodeTracer returns the correct revert reason for reverting HTS calls by taking the right contract action with the index that is tracked:
try to locally deploy a test contract which does different nested contract calls, some of which are reverting HTS calls, and then hit the contract/results/{transactionIdOrHash}/opcodes endpoint to replay the transaction and debug the OpcodeTracer to verify that the contractActionIndexOfCurrentFrame is correct when we hit the tracePrecompileCall method for the HTS calls
Problem
Currently the way that the
contractActionIndexOfCurrentFrameis tracked insideOpcodeTraceris not exactly how it is done in theHederaTracer, where the list of contract actions is built and we are still using the mono code in theweb3module, so we need to refactor this to be identical to what is done inHederaTracer. We need to copy the logic from there and increment thecontractActionIndexOfCurrentFramein the places where items are pushed to theallActionslist inHederaTracer.Solution
Copy the way contract actions are added to the
allActionslist in HederaTracerinit,tracePrecompileResult,traceAccountCreationResult, andtracePostExecutioneth_call,eth_estimateGasanddebug_traceTransactionmethodsOpcodeTracerreturns the correct revert reason for reverting HTS calls by taking the right contract action with the index that is tracked:contract/results/{transactionIdOrHash}/opcodesendpoint to replay the transaction and debug theOpcodeTracerto verify that thecontractActionIndexOfCurrentFrameis correct when we hit thetracePrecompileCallmethod for the HTS callsAlternatives
No response